Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove class_load_hooks and ClassLoadHook #321

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Remove class_load_hooks and ClassLoadHook #321

merged 2 commits into from
Oct 20, 2020

Conversation

kitchoi
Copy link
Contributor

@kitchoi kitchoi commented Oct 20, 2020

Closes #244

I too could not find uses of class_load_hook nor ClassLoadHook in ETS projects.

rahulporuri
rahulporuri approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like there is no documentation around the class load hooks and I can't find any other references to class load hooks in envisage source.

@kitchoi kitchoi merged commit afbdf18 into master Oct 20, 2020
@kitchoi kitchoi deleted the remove-class_load_hooks branch October 20, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove class_load_hooks extension point?
2 participants
@kitchoi @rahulporuri