Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Hello_World example #318

Merged
merged 3 commits into from
Oct 21, 2020
Merged

Fix the Hello_World example #318

merged 3 commits into from
Oct 21, 2020

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Oct 20, 2020 •
edited
Loading

The fix is fairly trivial - it is replacing logging.StreamHandler with logging.FileHandler.

FIX : Fix Hello_World example
fb3254a 
The fix is fairly trivial - it is replacing file with open.
file was python 2 only, which we can replace with open on python 3

	modified:   examples/Hello_World/hello_world.py
@kitchoi
Copy link
Contributor

kitchoi commented Oct 20, 2020

Appveyor build failed with this:

[EXECUTING] C:\Users\appveyor\.edm\envs\edm\Scripts\edm.EXE install -y -e envisage-test-3.6-pyqt5 traits pyqt5 coverage enthought_sphinx_theme traitsui ipykernel flake8 pyface apptools sphinx
Fetching indices for package repositories.. done
All Fetching package harfbuzz attempts failed
HTTPSConnectionPool(host='package-data.enthought.com', port=443): Max retries exceeded with url: 
...

@rahulporuri
Copy link
Contributor Author

I restarted the PR. It seems to be an intermittent failure. log(2).txt

FIX : Use FileHandler instead of StreamHandler
f25089c 
for logging the Hello_World application

	modified:   hello_world.py
kitchoi
kitchoi approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CLN : utf-8, not utf8
d5fedd3 
just to use what the rest of the codebase uses
@rahulporuri rahulporuri merged commit 14a0393 into master Oct 21, 2020
@rahulporuri rahulporuri deleted the fix/Hello_World_example branch October 21, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitchoi kitchoi kitchoi approved these changes

@mdickinson mdickinson mdickinson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulporuri @kitchoi @mdickinson