Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slack notification for Travis CI runs #283

Merged
merged 2 commits into from
May 11, 2020

Conversation

mdickinson
Copy link
Member

This PR adds Slack notification to the Enthought internal #ets-bots Slack channel.

cf. enthought/traits#1074

@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   53.80%   53.80%           
=======================================
  Files         135      135           
  Lines        4394     4394           
  Branches      511      511           
=======================================
  Hits         2364     2364           
  Misses       1989     1989           
  Partials       41       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85a0ec...38e934b. Read the comment docs.

@mdickinson
Copy link
Member Author

@rahulporuri Do you have bandwidth for a review?

@rahulporuri
Copy link
Contributor

@rahulporuri Do you have bandwidth for a review?

Yes I can but not immediately (i.e. in 2 hours).

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes look similar to what happened in traits.

@mdickinson
Copy link
Member Author

Thanks! Merging.

@mdickinson mdickinson merged commit 7e34145 into master May 11, 2020
@mdickinson mdickinson deleted the ci/add-slack-notifications branch May 11, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants