-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate safeweakref and replace its uses #275
Conversation
…the ProviderExtensionRegistry tests
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=========================================
+ Coverage 53.78% 53.8% +0.01%
=========================================
Files 135 135
Lines 4397 4394 -3
Branches 511 511
=========================================
- Hits 2365 2364 -1
+ Misses 1991 1989 -2
Partials 41 41
Continue to review full report at Codecov.
|
@corranwebster I've been self-merging a good few Envisage PRs (bad Mark!), but this one could probably use a review, if you have the bandwidth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some
safeweakref
-related cleanup, aimed at eventual removal of thesafeweakref
module.safeweakref
a drop-in replacement forweakref
:safeweakref
no longer doesfrom weakref import *
safeweakref.ref
safeweakref
with a simpler, private version that still handles bound methods specially, but doesn't do the caching thatsafeweakref
doessafeweakref.ref
safeweakref
flake8-clean, and remove it from the flake8 exclusion list.Closes #271