Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 check to etstool and CI #268

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Add flake8 check to etstool and CI #268

merged 2 commits into from
Feb 24, 2020

Conversation

mdickinson
Copy link
Member

This PR:

  • adds a flake8 command to etstool.py
  • uses that flake8 command in Travis CI and Appveyor
  • adds sufficient exclusions and ignorances to the setup.cfg to make the flake8 check pass;

The intent is to make the actual flake8 fixes (and reduce the size of the list of ignored warnings and errors) in separate PRs; this PR is focused simply on the infrastructure.

WIP because this may involve fiddling until the Appveyor and Travis runs are doing the right thing.

@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f596013). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #268   +/-   ##
========================================
  Coverage          ?   53.1%           
========================================
  Files             ?     135           
  Lines             ?    4425           
  Branches          ?     518           
========================================
  Hits              ?    2350           
  Misses            ?    2032           
  Partials          ?      43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f596013...2029290. Read the comment docs.

@mdickinson mdickinson changed the title WIP: Add flake8 check to etstool and CI Add flake8 check to etstool and CI Feb 18, 2020
@mdickinson
Copy link
Member Author

Working now; ready for review.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 4674dd4 into master Feb 24, 2020
@mdickinson mdickinson deleted the ci/flake8 branch February 24, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants