Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 4.9.2 release containing fix for tests that depend on Categories #263

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

mdickinson
Copy link
Member

The test suite for Envisage 4.9.1 fails against the latest release of Traits (Traits 6.0.0), due to the removal of Traits categories. (Envisage master no longer depends on Traits categories; so this is only an issue in this release series.)

This PR "fixes" the issue by skipping the relevant tests if Traits categories are not available.

Also bumps the version number and updates the changelog in preparation for a 4.9.2 release.

@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #263 into release/4.9.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/4.9.x     #263   +/-   ##
==============================================
  Coverage          54.18%   54.18%           
==============================================
  Files                138      138           
  Lines               4503     4503           
  Branches             526      526           
==============================================
  Hits                2440     2440           
  Misses              2018     2018           
  Partials              45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bbaad...7fc9ee0. Read the comment docs.

Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as is.

There may be a point to detecting that categories are unavailable and warning in the main envisage codebase (eg. if you try to instantiate an envisage.category.Category) if someone tries to use them, but that may be more effort than is worth it for this.

@mdickinson
Copy link
Member Author

but that may be more effort than is worth it for this.

That was pretty much the conclusion I came to, given that all this is gone in the upcoming release.

@mdickinson mdickinson merged commit 1d249fa into release/4.9.x Feb 17, 2020
@mdickinson mdickinson deleted the fix-category-tests branch February 17, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants