Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edm version and config/install scripts #236

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Nov 18, 2019

This PR prempts CI failures seen on other ETS packages related to invalid metadata found in new eggs.

NOTE : Ensure that we install the cli installer and not the full edm installer - which is very large in size and install the GUI which is not needed on the CI machines.

See similar PR in traits here - enthought/traits#560

NOTE : Ensure that we install the cli installer and not the full
edm installer - which is very large in size and install the GUI
which is not needed on the CI machines

	modified:   .travis.yml
	modified:   appveyor.yml
	modified:   install-edm-linux.sh
	modified:   install-edm-osx.sh
	modified:   install-edm-windows.cmd
@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #236 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   54.11%   54.07%   -0.05%     
==========================================
  Files         138      138              
  Lines        4496     4496              
  Branches      510      525      +15     
==========================================
- Hits         2433     2431       -2     
- Misses       2018     2019       +1     
- Partials       45       46       +1
Impacted Files Coverage Δ
envisage/composite_plugin_manager.py 84.21% <0%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d947a4d...d3a1568. Read the comment docs.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit 6551ff6 into master Nov 18, 2019
@mdickinson mdickinson deleted the fix/update-edm branch November 19, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants