Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of 0 and 1 with False and True, where appropriate. #993

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Aug 11, 2022

Note that in some cases there are more modern idioms that might be used, but fixing those is for another PR looking at the actual code, it might be worth the effort to make them more idiomatic (eg. is_dashed should be much clearer as a one-liner).

Note that in some cases there are more modern idioms that might be used,
but fixing those is for another PR.
@corranwebster corranwebster marked this pull request as ready for review August 12, 2022 10:22
@corranwebster corranwebster marked this pull request as draft August 12, 2022 10:22
@corranwebster corranwebster marked this pull request as ready for review January 13, 2023 15:09
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit 03bb941 into main Apr 18, 2023
@corranwebster corranwebster deleted the enh/use-bool branch April 18, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants