-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map MODERN
to "monospace"
and TELETYPE
to "typewriter"
#977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is less than ideal, as it doesn't distinguish between serif and sans-serif monospaced fonts, but it will suit as a bugfix until something better can be done.
This will keep the appearance the same.
Converting this to draft as there are other paths which get to |
corranwebster
changed the title
Map
Map May 2, 2023
MODERN
to "monospace"
MODERN
to "monospace"
and TELETYPE
to "typewriter"
This has been fixed up and is ready for review. |
dpinte
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
corranwebster
added a commit
to enthought/chaco
that referenced
this pull request
May 16, 2023
This should be equivalent for currently released Enable, but will keep things unchanged after [enable #977](enthought/enable#977) is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes font handling to:
Replaces uses of "modern" with "sans-serif" where appropriate (particularly in defaults) to keep appearances the same.
This now renders the benchmark like this (see the "mono" and "type" columns in particular):
This is not backwards compatible: users who use "modern" font family will get different fonts, but it is easily fixed by changing the font family. So this should probably be part of a major release.
Fixes #974.