Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.8 support #927

Merged
merged 8 commits into from
Apr 6, 2022
Merged

Python 3.8 support #927

merged 8 commits into from
Apr 6, 2022

Conversation

corranwebster
Copy link
Contributor

This is mainly adding support in CI, as we haven't identified any 3.8-specific issues.

If it works, closes #894.

@corranwebster corranwebster marked this pull request as draft April 6, 2022 14:13
@corranwebster corranwebster marked this pull request as ready for review April 6, 2022 14:43
@corranwebster corranwebster reopened this Apr 6, 2022
mdickinson
mdickinson approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson
Copy link
Member

LEGTM

@corranwebster
Copy link
Contributor Author

LEGTM

Even Gooder?

@corranwebster corranwebster merged commit fa865d8 into main Apr 6, 2022
@corranwebster corranwebster deleted the enh/python-3.8-edmtool branch April 6, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.8 Support
2 participants
@corranwebster @mdickinson