Replace RGBAColor Trait with something more modern. #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similar to the PyfaceColor Trait in Pyface, except that the value held is a RGBA tuple.
rkern
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to the PyfaceColor Trait in Pyface, except that the value held is a RGBA tuple.
This makes a few changes in the way that colors are parsed, using the parser from Pyface which is a but more accepting in what it recognizes, but should match all color names (since the Pyface names were copied from Enable). It also will accept a Pyface
Colorobject and convert it to a tuple.Part of #417, also relevant for #913 (but not all that is needed).