Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity check dash arguments #910

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Sanity check dash arguments #910

merged 2 commits into from
Mar 16, 2022

Conversation

corranwebster
Copy link
Contributor

Fixes #909.

jwiggins
jwiggins approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit 8dc913d into main Mar 16, 2022
@jwiggins jwiggins deleted the fix/celiagg-dash-sanity branch March 16, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiggins jwiggins jwiggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Celiagg backend freezes if passed a dash specification with total length 0 or less
2 participants
@corranwebster @jwiggins