Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_qt4 checks #852

Closed
wants to merge 2 commits into from
Closed

Remove is_qt4 checks #852

wants to merge 2 commits into from

Conversation

aaronayres35
Copy link
Contributor

Targeting stop-testing-pyqt4. This PR sits on top of #851 and removes is_qt4 checks from the code base.

@rahulporuri
Copy link
Contributor

We can't remove code that handles qt4 from the codebase yet. Removing it from the testsuite is still acceptable but not from the package itself. We'll have to close/shelve this (and PRs like these until later).

Base automatically changed from stop-testing-pyqt4 to master June 15, 2021 11:25
@aaronayres35
Copy link
Contributor Author

We can't remove code that handles qt4 from the codebase yet. Removing it from the testsuite is still acceptable but not from the package itself. We'll have to close/shelve this (and PRs like these until later).

I sort of figured this was too much too soon, but opened the PR anyway as it was fresh on my mind. We can shelve these until they are ready

@corranwebster
Copy link
Contributor

This is fixed by #1043

@jwiggins jwiggins deleted the remove-is_qt4-checks branch April 21, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants