Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle preferred size computation when container isnt resizable #778

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Handle preferred size computation when container isnt resizable #778

merged 2 commits into from
Apr 26, 2021

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Apr 16, 2021 •
edited
Loading

Ref enthought/chaco#673. enthought/chaco#673 got closed in favor of enthought/chaco#674

It looks like these lines were commented out from the original commit when this code was added to enable in 75fb3ac
and subsequently, the commented out code was removed in the PR #466

Poruri Sai Rahul added 2 commits April 16, 2021 06:48
DOC : Remove now outdated comment string
2b3bd72 
Ref https://github.com/enthought/chaco/pull/673/files
FIX : Handle case when container.resizable is none
0c9288e 
it looks like these lines were commented out from the original commit when
this code was added to enable in 75fb3ac
and subsequently, the commented out code was removed in the PR
#466
@rahulporuri rahulporuri changed the title Remove now outdated comment string Handle preferred size computation when container isnt resizable Apr 16, 2021
aaronayres35
aaronayres35 approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I see the same code in chaco. Unclear to me why it had been commented out.

@rahulporuri rahulporuri merged commit 7b45517 into master Apr 26, 2021
@rahulporuri rahulporuri deleted the rahulporuri-patch-1 branch April 26, 2021 04:32
@aaronayres35 aaronayres35 mentioned this pull request May 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulporuri @aaronayres35