Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split kiva.fonttools._scanner into two modules #695

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Split kiva.fonttools._scanner into two modules #695

merged 1 commit into from
Mar 10, 2021

Conversation

jwiggins
Copy link
Member

As discussed in #693

rahulporuri
rahulporuri approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwiggins jwiggins merged commit 01c9974 into master Mar 10, 2021
@jwiggins jwiggins deleted the refactor/split-font-scanner branch March 10, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwiggins @rahulporuri