Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QPainter fill_path #660

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fix QPainter fill_path #660

merged 1 commit into from
Mar 2, 2021

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Mar 2, 2021

Fixes #657.

This was trivial.

rahulporuri
rahulporuri approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested this fix using the benchmark.

@jwiggins jwiggins merged commit 7cc3b1e into master Mar 2, 2021
@jwiggins jwiggins deleted the fix/qpainter-draw-rect branch March 2, 2021 09:22
@aaronayres35 aaronayres35 mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

draw_rect behaves weirdly with QPainter backend
2 participants
@jwiggins @rahulporuri