Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenGL support to the benchmark program #659

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Add OpenGL support to the benchmark program #659

merged 1 commit into from
Mar 2, 2021

Conversation

jwiggins
Copy link
Member

@jwiggins jwiggins commented Mar 2, 2021

Fixes #652

This wasn't as hard as I thought it would be. I just stole code from the kiva drawing tests.

@rahulporuri
Copy link
Contributor

- x 2x
draw marker at points opengl draw_marker_at_points opengl draw_marker_at_points 2x
draw path at points opengl draw_path_at_points opengl draw_path_at_points 2x
show text opengl show_text opengl show_text 2x
draw path opengl draw_path opengl draw_path 2x

rahulporuri
rahulporuri approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The code worked as expected locally but there were a bunch of issues that I got to know about looking at the output of the benchmark.

@jwiggins
Copy link
Member Author

jwiggins commented Mar 2, 2021

Yeah. The OpenGL backend is pretty rotted.

Thanks for the review.

@jwiggins jwiggins merged commit 0ddaa89 into master Mar 2, 2021
@jwiggins jwiggins deleted the feature/gl-benchmark branch March 2, 2021 09:21
@aaronayres35 aaronayres35 mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kiva Benchmark: Add OpenGL
2 participants
@jwiggins @rahulporuri