Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a celiagg kiva backend for Wx #608

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Add a celiagg kiva backend for Wx #608

merged 1 commit into from
Feb 24, 2021

Conversation

jwiggins
Copy link
Member

Looking towards #414, we should have a celiagg backend for Wx. This PR supplies one.

@rahulporuri
Copy link
Contributor

I see the following tracebacks from the command line when i run the kiva explorer demo in the wx backend + celiagg backend.

> set ETS_TOOLKIT="wx.celiagg"
> python kiva_explorer.py
Traceback (most recent call last):
  File "C:\Users\rporuri\.edm\envs\enable-test-3.6-wx\lib\site-packages\traitsui\wx\code_editor.py", line 375, in _style_needed
    self.control.StartStyling(position, stc.STC_INDIC2_MASK)
TypeError: StyledTextCtrl.StartStyling(): too many arguments
Traceback (most recent call last):
  File "C:\Users\rporuri\.edm\envs\enable-test-3.6-wx\lib\site-packages\traitsui\wx\code_editor.py", line 375, in _style_needed
    self.control.StartStyling(position, stc.STC_INDIC2_MASK)
TypeError: StyledTextCtrl.StartStyling(): too many arguments
Traceback (most recent call last):
  File "C:\Users\rporuri\.edm\envs\enable-test-3.6-wx\lib\site-packages\traitsui\wx\code_editor.py", line 375, in _style_needed
    self.control.StartStyling(position, stc.STC_INDIC2_MASK)
TypeError: StyledTextCtrl.StartStyling(): too many arguments

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested the changes by setting the ETS_TOOLKIT environment variable to wx.celiagg and running the kiva_explorer. Apart from a few unrelated traitsui errors, this seems to do the job.

@jwiggins
Copy link
Member Author

Thanks for the review!

@jwiggins jwiggins merged commit c78ee6f into master Feb 24, 2021
@jwiggins jwiggins deleted the feature/wx-celiagg branch February 24, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants