Skip to content

Added python 3.5 and 3.6 as targets #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 2, 2017

Conversation

jdeschenes
Copy link
Contributor

@jdeschenes jdeschenes commented Jul 25, 2017

Seems like it will fix #274 as well.

@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   33.22%   33.22%           
=======================================
  Files         206      206           
  Lines       18559    18559           
  Branches     2520     2520           
=======================================
  Hits         6167     6167           
  Misses      11998    11998           
  Partials      394      394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa33701...869a75b. Read the comment docs.

Added build steps for python 3.5 and python 3.6 with qt.
@jdeschenes
Copy link
Contributor Author

How do you propose to fix the build error for python 3 and qt?

The pyside-setup only includes builds for 3.4, even though it looks
like the build for python 3.5 and 3.6 should be supported.
@jwiggins
Copy link
Member

See #281. I'll merge that soon and then this branch will need to be rebased/adapted

@jdeschenes
Copy link
Contributor Author

No problem. The changes in this branch are very minor.

@jdeschenes
Copy link
Contributor Author

Is there any reason why pyqt is not tested during the travis CI run?

@jwiggins
Copy link
Member

I think that's a relic of the days when it was thought that PySide would be the Qt binding going forward.... but don't quote me on that.

@jwiggins
Copy link
Member

This should only need an update to .travis.yml now that #281 is merged

@jwiggins
Copy link
Member

jwiggins commented Aug 2, 2017

LGTM!

@jwiggins jwiggins merged commit 38e401c into enthought:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous integration broken on Python 3.x / Qt+PySide
3 participants