-
Notifications
You must be signed in to change notification settings - Fork 45
Added python 3.5 and 3.6 as targets #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 33.22% 33.22%
=======================================
Files 206 206
Lines 18559 18559
Branches 2520 2520
=======================================
Hits 6167 6167
Misses 11998 11998
Partials 394 394 Continue to review full report at Codecov.
|
Added build steps for python 3.5 and python 3.6 with qt.
How do you propose to fix the build error for python 3 and qt? |
The pyside-setup only includes builds for 3.4, even though it looks like the build for python 3.5 and 3.6 should be supported.
See #281. I'll merge that soon and then this branch will need to be rebased/adapted |
No problem. The changes in this branch are very minor. |
Is there any reason why pyqt is not tested during the travis CI run? |
I think that's a relic of the days when it was thought that PySide would be the Qt binding going forward.... but don't quote me on that. |
This should only need an update to |
# Conflicts: # .travis.yml # build_pyside_wheel.sh
LGTM! |
Seems like it will fix #274 as well.