-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template test case for graphic contexts #160
Conversation
…ase-for-graphic-contexts
The problem is related to pyglet tring to save into png, but I cannot reproduce it locally. I will need to investigate a little more. One of the items that concerns me is that our requirement file installs PIL but one of the other requirements.,I think enaml, installs pillow. It looks that pillow overwrites PIL and It might be that pillow does not play nice with pyglet. |
I was able to reproduce the bug locally. It is actually a pyglet bug |
wget -nv http://cairographics.org/releases/py2cairo-1.10.0.tar.bz2 | ||
tar -xf py2cairo-1.10.0.tar.bz2 | ||
pushd py2cairo-1.10.0 | ||
,/waf configure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
…ments are not available
Finally the tests pass, pending some cleanup and the this PR will be ready for review. |
This PR is now ready for review |
class TestAggDrawing(DrawingImageTester, unittest.TestCase): | ||
|
||
def setUp(self): | ||
DrawingImageTester.setUp(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. DrawingImageTester
subclass DrawingTester
which has a setUp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see, what you mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes you are right it is not necessary
That's all I got. This is a huge improvement! |
PR updated, open issues about the known failures |
Awesome. Thanks for the tests @itziakos and welcome to the codebase Peo! |
…-contexts Template test case for graphic contexts
This is a PR that factors out a template test mixin to be used for testing the basic functionality of the kiva backends. This PR based on the work of peowebster:test/drawing-tests
pending: