Skip to content

Template test case for graphic contexts#160

Merged
jwiggins merged 74 commits into
masterfrom
template-test-case-for-graphic-contexts
Dec 12, 2014
Merged

Template test case for graphic contexts#160
jwiggins merged 74 commits into
masterfrom
template-test-case-for-graphic-contexts

Conversation

@itziakos

Copy link
Copy Markdown
Member

This is a PR that factors out a template test mixin to be used for testing the basic functionality of the kiva backends. This PR based on the work of peowebster:test/drawing-tests

pending:

  • add all the current kiva backends
  • update dependencies for travis-ci builds
  • fix errors
  • cleanup

@itziakos

Copy link
Copy Markdown
Member Author

The problem is related to pyglet tring to save into png, but I cannot reproduce it locally. I will need to investigate a little more. One of the items that concerns me is that our requirement file installs PIL but one of the other requirements.,I think enaml, installs pillow. It looks that pillow overwrites PIL and It might be that pillow does not play nice with pyglet.

@itziakos

Copy link
Copy Markdown
Member Author

I was able to reproduce the bug locally. It is actually a pyglet bug

Comment thread .travis_before_install Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@itziakos itziakos changed the title Template test case for graphic contexts [WIP] Template test case for graphic contexts Nov 28, 2014
@itziakos

Copy link
Copy Markdown
Member Author

Finally the tests pass, pending some cleanup and the this PR will be ready for review.

@itziakos itziakos changed the title [WIP] Template test case for graphic contexts Template test case for graphic contexts Dec 12, 2014
@itziakos

Copy link
Copy Markdown
Member Author

This PR is now ready for review

Comment thread kiva/tests/test_agg_drawing.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. DrawingImageTester subclass DrawingTester which has a setUp

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, what you mean

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you are right it is not necessary

@jwiggins

Copy link
Copy Markdown
Member

That's all I got. This is a huge improvement!

@itziakos

Copy link
Copy Markdown
Member Author

PR updated, open issues about the known failures

@jwiggins

Copy link
Copy Markdown
Member

Awesome. Thanks for the tests @itziakos and welcome to the codebase Peo!

jwiggins added a commit that referenced this pull request Dec 12, 2014
…-contexts

Template test case for graphic contexts
@jwiggins jwiggins merged commit 70c1460 into master Dec 12, 2014
@jwiggins jwiggins deleted the template-test-case-for-graphic-contexts branch December 12, 2014 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants