Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a very basic Image component #150

Merged
merged 10 commits into from
Jan 6, 2015
Merged

Add a very basic Image component #150

merged 10 commits into from
Jan 6, 2015

Conversation

corranwebster
Copy link
Contributor

...because using a Chaco ImagePlot to display a simple .png is Wrong.

@itziakos
Copy link
Member

itziakos commented Oct 3, 2014

We should add some basic testing for the object initialization with contrinuous and non-continues images and the from_file constructor. Drawing can be smoke tested by comparing drawn image in a back buffer.

@itziakos itziakos self-assigned this Oct 3, 2014
jwiggins
jwiggins reviewed Dec 19, 2014
View reviewed changes
examples/enable/image_draw.py
path = os.path.join(THIS_DIR, 'deepfield.jpg')
image = Image.from_file(path)
image.resist_width = 'weak'
image.resist_height = 'weak'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of adding a **traits argument to Image.from_file? Then this could be Image.from_file(path, resist_width='weak', resist_height='weak')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on that. I'll quickly add that to the PR.

@jwiggins jwiggins modified the milestone: Version 4.5.0 Jan 5, 2015
@jwiggins
Copy link
Member

jwiggins commented Jan 5, 2015

@itziakos: Do you have time to finish this before the end of the month? I'd like to make it part of the next release.

@corranwebster
Copy link
Contributor Author

I'm writing up some tests now.

@corranwebster
Copy link
Contributor Author

@jwiggins The tests are pretty comprehensive at this point. I think that this is good to be merged.

@jwiggins
Copy link
Member

jwiggins commented Jan 6, 2015

Sweet! Thanks for the fast turnaround @corranwebster

@jwiggins
Copy link
Member

jwiggins commented Jan 6, 2015

Thanks for the feature! 👍

Coverage Status

jwiggins added a commit that referenced this pull request Jan 6, 2015
@jwiggins
Merge pull request #150 from enthought/feature/image-component
0b881f4 
Add a very basic Image component
@jwiggins jwiggins merged commit 0b881f4 into master Jan 6, 2015
@jwiggins jwiggins deleted the feature/image-component branch January 6, 2015 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@corranwebster corranwebster

Labels
None yet
Projects
None yet
Milestone
Version 4.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@corranwebster @itziakos @jwiggins