Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove all mentions of unittest2. #320

Closed
wants to merge 7 commits into from

Conversation

jvkersch
Copy link
Contributor

Drive-by PR to remove all uses of unittest2, given that the lowest supported Python version is 2.7.

@jvkersch
Copy link
Contributor Author

jvkersch commented Nov 1, 2016

@itziakos Do you have any idea what might be going on here? This is the PR that I mentioned was getting killed during python setup.py develop. The Travis build log showed that this consistently happened during the enable build, more precisely while installing six. Manually doing pip install six before the enable build seems to fix the issue...

@corranwebster
Copy link
Contributor

@jvkersch if six isn't already installed, then Enable's setup.py will probably try to install via easyinstall/setuptools (I think) rather than pip. So possibly some issue with setuptools and/or installing six via setuptools?

Enable has a rather nasty setup.py system, so it wouldn't shock me if there is something bad there.

@jvkersch
Copy link
Contributor Author

jvkersch commented Nov 2, 2016

That's possible. This is the line where it goes wrong in the build log:

Running six-1.10.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-ctwu5nzk/six-1.10.0/egg-dist-tmp-lic6svep

Shall we just add six to Enable's Travis requirements?

@corranwebster
Copy link
Contributor

Yes.

@jvkersch jvkersch mentioned this pull request Nov 2, 2016
@jvkersch jvkersch closed this Nov 2, 2016
@jvkersch jvkersch deleted the maint/remove-unittest2 branch November 2, 2016 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants