added ready status update when all components are ready#19
Draft
added ready status update when all components are ready#19
Conversation
antromeo
commented
Nov 11, 2022
| // An EntandoAppV2 deploys the components required to upgrade an Entando App. The server side | ||
| // components that are deployed include the Entando App Engine, the Entando Component Manager, | ||
| // the Entando App Builder, and the user facing application. | ||
| // +kubebuilder:printcolumn:name="Ready",type="string",JSONPath=`.status.conditions[?(@.type=="Ready")].status`,description="state of EntandoApp" |
Collaborator
Author
There was a problem hiding this comment.
adds additionalPrinterColumns to CRD, in this way it's easier to see its evolution with kubectl
antromeo
commented
Nov 11, 2022
| // FIXME! add filter on create for EntandoAppV2 cr | ||
| For(&v1alpha1.EntandoAppV2{}). | ||
| WithEventFilter(predicate.GenerationChangedPredicate{}). //solo modifiche a spec | ||
| For(&v1alpha1.EntandoAppV2{}, utils.ForOptionCustom()). |
Collaborator
Author
There was a problem hiding this comment.
custom predicates can be used in For and in Watches methods, in this way it is possible to filter the events based on the type of resource, for example different behaviors from CR and deployments events can be used
antromeo
commented
Nov 11, 2022
| Succeeded = "Succeeded" | ||
| Ready = "Ready" | ||
| Succeeded = "Succeeded" | ||
| Initialized = "Initialized" |
Collaborator
Author
There was a problem hiding this comment.
I only used Ready and Initialized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.