[mob][photos] Fix free up space bug #5231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to photo_manager's deleteWithIds() when using free up space feature to avoid complete failure of free up space operation
…ving non-existing assets (only for android)
… during free up space only if freeing up space without it fails This is to make free up space faster in most cases
ua741
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If free up space fails, now we retry after removing
localIDsthat have no asset returned by Photo Manager. If it still fails, we re-try after running this.Note: It's not clear if this fixes received bug reports since we haven't been able to reproduce deleteWithIds failing on using the Free up space feature.