Skip to content

[mob][photos] Bug fixes for contact-person linking feature #4931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Feb 1, 2025

Conversation

ashilkn
Copy link
Member

@ashilkn ashilkn commented Feb 1, 2025

No description provided.

… in all screen related to collaborative albums created by the account owner
…creens (Reassign me & Link contact to person)
…ent is fired only after cache is updated. Else there is chance that UI is rebuild on PeopleChangedEvent with stale state of EmailToNameCahce
…n contacts section and search results that come up when searching
…inking or un-linking person from the contact
…ll then be used as the base list to further filter suggestions in the 'Link Email' screen and the 'Add Participants to Album' screen.

The number of emails suggested in the 'Add Participants to Album' screen will now be higher than before, yet still useful.
…on add participant page and possibly in link email screen as well
@ashilkn ashilkn enabled auto-merge February 1, 2025 09:14
@ashilkn ashilkn requested a review from ua741 February 1, 2025 09:44
@ashilkn ashilkn merged commit 14fbec6 into main Feb 1, 2025
3 checks passed
@ashilkn ashilkn deleted the contact_person_linking_fixes branch February 1, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants