-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[mob][photos] Bug fixes for contact-person linking feature #4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in all screen related to collaborative albums created by the account owner
…creens (Reassign me & Link contact to person)
…ssary update events" This reverts commit 11d080f.
This reverts commit cf977a7.
… tab" This reverts commit 628f195.
…ent is fired only after cache is updated. Else there is chance that UI is rebuild on PeopleChangedEvent with stale state of EmailToNameCahce
…person-data cache
…n contacts section and search results that come up when searching
…inking or un-linking person from the contact
…on screen to match figma design
…ll then be used as the base list to further filter suggestions in the 'Link Email' screen and the 'Add Participants to Album' screen. The number of emails suggested in the 'Add Participants to Album' screen will now be higher than before, yet still useful.
…on add participant page and possibly in link email screen as well
…ities sync (right after logging in)
ua741
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.