Skip to content

ENG-4851 fix console warnings for reactour and errors #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ichalagashvili merged 1 commit into from
May 12, 2023
Merged

ENG-4851 fix console warnings for reactour and errors #1484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 64 additions & 88 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"react-router-dom": "^5.2.0",
"react-roving-tabindex": "^1.0.0",
"react-test-renderer": "^16.14.0",
"reactour": "^1.18.0",
"reactour": "^1.19.0",
"redux": "^4.0.1",
"redux-form": "^8.3.7",
"redux-localstorage": "^0.4.1",
Expand Down
17 changes: 17 additions & 0 deletions src/ui/app-tour/AppTour.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,23 @@ import { disableBodyScroll, enableBodyScroll } from 'body-scroll-lock';
import { FormattedMessage } from 'react-intl';
import { APP_TOUR_CANCELLED, APP_TOUR_STARTED } from 'state/app-tour/const';

// This mutes warnings and errors of the library
// eslint-disable-next-line no-console
const originalWarn = console.warn;

// eslint-disable-next-line no-console
console.warn = (message, ...args) => {
if (
typeof message === 'string' &&
message.includes("Please check the 'steps' Tour prop Array at position")
) {
return; // Ignore the warning
}

// Log the warning
originalWarn.apply(console, [message, ...args]);
};

const mouseClickEvents = ['mouseover', 'hover', 'mousedown', 'click', 'mouseup'];
export const simulateMouseClick = (element) => {
mouseClickEvents.forEach(mouseEventType =>
Expand Down