Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Visualization Fixes #1804

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Visualization Fixes #1804

merged 4 commits into from
Aug 20, 2021

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Aug 19, 2021

Pull Request Description

IDE will retry attaching visualizations only if the error is timeout;
fixed an issue in FRP which led to visualizations not being detached when hidden.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@mwu-tow mwu-tow added Category: Controllers The Application layer not bound to visual part Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE labels Aug 19, 2021
@MichaelMauderer MichaelMauderer merged commit 838788a into develop Aug 20, 2021
@MichaelMauderer MichaelMauderer deleted the wip/mwu/visualization-fixes branch August 20, 2021 07:37
mwu-tow added a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Controllers The Application layer not bound to visual part Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants