This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Searcher Fixes #1577
Merged
Searcher Fixes #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
Category: BaseGL
wdanilo
reviewed
May 24, 2021
There was a problem hiding this comment.
It looks super cool! I'm so happy it is implemented <3 Before approving though, I'd love to see it working on a screencast - especially the mouse transitions - please move mouse very slowly, so the transitions will be visible in the movie and we could catch any graphical issues with them.
Comment on lines
+643
to
+644
| let panel = layers.new_layer(); | ||
| let panel_text = layers.new_layer(); |
There was a problem hiding this comment.
Add a short description what a panel could contain, please.
wdanilo
approved these changes
May 25, 2021
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
Original commit: enso-org/ide@de6e145
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR make some visual fixes of the searcher:
Important Notes
The fix in point 2. needs a little work on cursors: currently the cursor has two layers you can switch between: the topmost cursor layer and "port selection" layer. The cursor keeps two shape, but only one keeps the actual color.
Additionally, removed _DEPRECATED from Area methods for layer management, as the methods cannot be deprecated if there is no other way in the API to achieve what such methods allow.
Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.All code has automatic tests where possible.