This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close and Fullscreen buttons for IDE in the cloud #1511
Close and Fullscreen buttons for IDE in the cloud #1511
Changes from 21 commits
0867867
4dd8f7a
ee404b2
276dcb2
0d0dff5
88bc77c
26c15c6
19b446d
4558998
ac5ae69
d581444
b61f6dc
d744947
6a0f6bd
6465135
4142bee
1288bc5
9c5ea17
1774e9e
c8babb1
83b2d5f
2fcc78c
dfbc9bf
6b10df4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont understand the name. Wjy there is "rannge" in name? We are consturctng colors not from a range, but from a 255-integer color encoding. I just think that the "range" word is very confusing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be implemented as
.glsl()
method on colors instead imo. This is how we are converting all values there. Moreover, I see inconsistency here -srgba
is a name used in GLSL due to convention there. However, in Rust, the counterpart ofsrgba
iscolor::Rgba
, while the counterpart of GLSL'srgba
iscolor::LinearRgba
. So the namesrgba
in Rust can be confusing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot be a
glsl
method, as the purpose is to constructVar<color:Rgba>
, notGlsl
.Also, it cannot be on color, as there is no color, just the variables with its components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alignment + these two impls are so similar, that you should create macro for them.