This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Add Enso_Project.data entry to the searcher #1393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
Difficulty: Intermediate
Some prior knowledge required
Priority: Highest
Should be completed ASAP
Type: Enhancement
An enhancement to the current state of Enso IDE
Category: Controllers
The Application layer not bound to visual part
labels
Mar 26, 2021
mwu-tow
approved these changes
Mar 26, 2021
//TODO[ao] this is a temporary workaround. | ||
fn add_enso_project_data_entry(actions:&action::List) -> FallibleResult { | ||
let entry = model::suggestion_database::Entry { | ||
name : "data".to_owned(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding same for root
method.
@@ -40,7 +40,7 @@ impl Action { | |||
} else { | |||
completion.name.clone() | |||
} | |||
Self::Example(example) => format!("Example: {}", example.name) | |||
Self::Example(example) => format!("Example: {}", example.name), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Category: Controllers
The Application layer not bound to visual part
Difficulty: Intermediate
Some prior knowledge required
Priority: Highest
Should be completed ASAP
Type: Enhancement
An enhancement to the current state of Enso IDE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is workaround for enso-org/enso#1605
Important Notes
Checklist
Please include the following checklist in your PR:
CHANGELOG.md
was updated with the changes introduced in this PR.The documentation has been updated if necessary.All code has automatic tests where possible.All code has been manually tested in the "debug/interface" scene.