Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Add Enso_Project.data entry to the searcher #1393

Merged
merged 5 commits into from
Mar 26, 2021
Merged

Conversation

farmaazon
Copy link
Collaborator

Pull Request Description

This is workaround for enso-org/enso#1605

Important Notes

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@farmaazon farmaazon added Difficulty: Intermediate Some prior knowledge required Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE Category: Controllers The Application layer not bound to visual part labels Mar 26, 2021
@farmaazon farmaazon requested a review from mwu-tow March 26, 2021 15:35
@farmaazon farmaazon requested a review from wdanilo as a code owner March 26, 2021 15:35
@farmaazon farmaazon self-assigned this Mar 26, 2021
//TODO[ao] this is a temporary workaround.
fn add_enso_project_data_entry(actions:&action::List) -> FallibleResult {
let entry = model::suggestion_database::Entry {
name : "data".to_owned(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding same for root method.

@@ -40,7 +40,7 @@ impl Action {
} else {
completion.name.clone()
}
Self::Example(example) => format!("Example: {}", example.name)
Self::Example(example) => format!("Example: {}", example.name),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

@farmaazon farmaazon merged commit a1b0a0d into develop Mar 26, 2021
@farmaazon farmaazon deleted the wip/ao/enso_project branch March 26, 2021 17:22
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Controllers The Application layer not bound to visual part Difficulty: Intermediate Some prior knowledge required Priority: Highest Should be completed ASAP Type: Enhancement An enhancement to the current state of Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants