Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Conversation

MichaelMauderer
Copy link
Contributor

@MichaelMauderer MichaelMauderer commented Mar 10, 2021

Pull Request Description

Fixes a bug where the default port was used instead of the correct server port when starting the IDE.

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
  • All code has been profiled where possible.
  • All code has been manually tested in the IDE.
  • All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@MichaelMauderer MichaelMauderer added Difficulty: Hard Significant prior knowledge requried Priority: High Should be scheduled as soon as possible Type: Bug A bug in Enso IDE labels Mar 10, 2021
@MichaelMauderer MichaelMauderer self-assigned this Mar 10, 2021
@MichaelMauderer MichaelMauderer force-pushed the wip/mm/ide-1196-ide-fails-to-launch-when-port-8080-is-open-with-another-process branch from 2c22c5e to 38fc289 Compare March 10, 2021 13:22
@MichaelMauderer MichaelMauderer marked this pull request as ready for review March 10, 2021 13:22
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if that woirks with cmd line args

src/js/lib/client/src/index.js Outdated Show resolved Hide resolved
@MichaelMauderer MichaelMauderer merged commit 0b49e93 into develop Mar 11, 2021
@MichaelMauderer MichaelMauderer deleted the wip/mm/ide-1196-ide-fails-to-launch-when-port-8080-is-open-with-another-process branch March 11, 2021 19:58
mwu-tow pushed a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: Hard Significant prior knowledge requried Priority: High Should be scheduled as soon as possible Type: Bug A bug in Enso IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants