This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Fix Main modules #1279
Merged
Fix Main modules #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
Category: Controllers
mwu-tow
approved these changes
Mar 2, 2021
| /// assert_eq!(main_but_not_library_main.remove_main_module_segment().to_string(), "Project.Foo.Main"); | ||
| /// ``` | ||
| pub fn remove_main_module_segment(mut self) -> Self { | ||
| if self.id.segments.len() == 1 && self.id.segments.last().contains_if(|s| s == &&LIBRARIES_MAIN_MODULE) { |
There was a problem hiding this comment.
Consider if can be simplified by comparison to vec!
| /// assert_eq!(name_without_main .remove_main_module_segment().to_string(), "Project.Foo.Bar"); | ||
| /// assert_eq!(main_but_not_library_main.remove_main_module_segment().to_string(), "Project.Foo.Main"); | ||
| /// ``` | ||
| pub fn remove_main_module_segment(mut self) -> Self { |
There was a problem hiding this comment.
perjaps should work on &mut self
| @@ -31,7 +31,12 @@ impl Action { | |||
| pub fn caption(&self) -> String { | |||
| match self { | |||
| Self::Suggestion(completion) => if let Some(self_type) = completion.self_type.as_ref() { | |||
| format!("{}.{}",self_type.name,completion.name) | |||
| let should_put_library_name = self_type.name == constants::LIBRARIES_MAIN_MODULE | |||
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
Original commit: enso-org/ide@79f906d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.All code has been manually tested in the "debug/interface" scene.