Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Prevent IDE from failing to start when metadata are invalid #1214

Merged
merged 9 commits into from
Feb 19, 2021

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Feb 18, 2021

Pull Request Description

See #1210

Important Notes

In future more localized metadata error handling should be implemented in the IDE metadata themselves, so only the invalid part is lost. This PR is orthogonal to this — no matter how metadata are broken, IDE should push on.

Checklist

Please include the following checklist in your PR:

  • The CHANGELOG.md was updated with the changes introduced in this PR.
  • The documentation has been updated if necessary.
  • All code conforms to the Rust style guide.
  • All code has automatic tests where possible.
    - [ ] All code has been profiled where possible.
  • All code has been manually tested in the IDE.
    - [ ] All code has been manually tested in the "debug/interface" scene.
  • All code has been manually tested by the PR owner against our test scenarios.
  • All code has been manually tested by at least one reviewer against our test scenarios.

@mwu-tow mwu-tow self-assigned this Feb 18, 2021
@mwu-tow mwu-tow marked this pull request as draft February 18, 2021 14:11
@mwu-tow mwu-tow marked this pull request as ready for review February 19, 2021 12:16
src/rust/ide/lib/parser/src/api.rs Outdated Show resolved Hide resolved
src/rust/ide/lib/utils/src/serde.rs Outdated Show resolved Hide resolved
@farmaazon farmaazon merged commit 07927e1 into develop Feb 19, 2021
@farmaazon farmaazon deleted the wip/mwu/handle-metadata-errors-1210 branch February 19, 2021 14:20
mwu-tow added a commit to enso-org/enso that referenced this pull request Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants