Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement relational NULL/Nothing for join for in-memory tables #8849

Merged
merged 76 commits into from
Jan 29, 2024

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Jan 24, 2024

Pull Request Description

Implements relational NULL for join, for all Join_Kinds.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review January 24, 2024 20:49
Copy link
Member

@AdRiley AdRiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something to fix for this PR, but in general I find

        t1 = table_builder [["X", ["A", Nothing, "a", Nothing, "ą", "b"]], ["Y", [0, 1, 2, 3, 4, 5]]]
        t2 = table_builder [["X", ["a", Nothing, Nothing, "b"]], ["Z", [10, 20, 30, 50]]]

really hard to read. To the point that I want to write it out on paper.

Do we have a better way of defining tables from text?

@GregoryTravis
Copy link
Contributor Author

Not something to fix for this PR, but in general I find

        t1 = table_builder [["X", ["A", Nothing, "a", Nothing, "ą", "b"]], ["Y", [0, 1, 2, 3, 4, 5]]]
        t2 = table_builder [["X", ["a", Nothing, Nothing, "b"]], ["Z", [10, 20, 30, 50]]]

really hard to read. To the point that I want to write it out on paper.

Do we have a better way of defining tables from text?

It's very tempting to write something to parse an ascii table.

But we could encourage the practice of defining tables as rows, not columns, that's somewhat easier to read.

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Jan 25, 2024
@mwu-tow mwu-tow added the CI: Keep up to date Automatically update this PR to the latest develop. label Jan 26, 2024
@mwu-tow mwu-tow removed the CI: Keep up to date Automatically update this PR to the latest develop. label Jan 26, 2024
@mergify mergify bot merged commit 7436848 into develop Jan 29, 2024
25 checks passed
@mergify mergify bot deleted the wip/gmt/8814-join-fc branch January 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants