Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Table.lookup_and_replace for in-memory #7979

Merged
merged 27 commits into from
Oct 10, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Oct 5, 2023

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd self-assigned this Oct 5, 2023
@radeusgd radeusgd changed the title Implement Table.lookup_and_replace Implement Table.lookup_and_replace for in-memory Oct 5, 2023
@radeusgd radeusgd force-pushed the wip/radeusgd/7749-lookup-table branch from 81f4615 to 55b83e4 Compare October 5, 2023 16:22
@radeusgd radeusgd marked this pull request as ready for review October 5, 2023 16:22
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments and suggestions but generally looks good.
Approving so you can move fwd after addressing.

@radeusgd radeusgd added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Ready to merge This PR is eligible for automatic merge labels Oct 9, 2023
@radeusgd
Copy link
Member Author

image

Added a widget for key_columns.

@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Oct 10, 2023
@mergify mergify bot merged commit 6e0bd86 into develop Oct 10, 2023
33 checks passed
@mergify mergify bot deleted the wip/radeusgd/7749-lookup-table branch October 10, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table "find and replace" function
3 participants