-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Table.lookup_and_replace
for in-memory
#7979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emory update_rows
radeusgd
changed the title
Implement
Implement Oct 5, 2023
Table.lookup_and_replace
Table.lookup_and_replace
for in-memory
radeusgd
force-pushed
the
wip/radeusgd/7749-lookup-table
branch
from
October 5, 2023 16:22
81f4615
to
55b83e4
Compare
GregoryTravis
approved these changes
Oct 5, 2023
std-bits/table/src/main/java/org/enso/table/data/table/join/LookupJoin.java
Show resolved
Hide resolved
jdunkerley
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and suggestions but generally looks good.
Approving so you can move fwd after addressing.
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/table/join/LookupJoin.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/table/join/LookupJoin.java
Outdated
Show resolved
Hide resolved
std-bits/table/src/main/java/org/enso/table/data/table/join/LookupJoin.java
Outdated
Show resolved
Hide resolved
radeusgd
added
CI: Ready to merge
This PR is eligible for automatic merge
and removed
CI: Ready to merge
This PR is eligible for automatic merge
labels
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Table.lookup_and_replace
for the Database backend #7981Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.