Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review generated Column names #5850

Merged
merged 26 commits into from
Mar 10, 2023
Merged

Review generated Column names #5850

merged 26 commits into from
Mar 10, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Mar 8, 2023

Pull Request Description

Closes #5583 and closes #5157

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@radeusgd radeusgd self-assigned this Mar 8, 2023
@radeusgd radeusgd marked this pull request as ready for review March 8, 2023 10:52
@radeusgd radeusgd force-pushed the wip/5583-database-column-names-review branch from c2bd473 to 3b95fa0 Compare March 8, 2023 12:41
@radeusgd radeusgd force-pushed the wip/5583-database-column-names-review branch from 3b95fa0 to 04157df Compare March 8, 2023 13:22
@radeusgd radeusgd force-pushed the wip/5583-database-column-names-review branch from 6c0fd58 to ac854e6 Compare March 8, 2023 20:27
@enso-bot enso-bot bot mentioned this pull request Mar 9, 2023
Closed
jdunkerley
jdunkerley approved these changes Mar 9, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Column.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Column.enso Outdated Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/5583-database-column-names-review branch from ac854e6 to 55f0611 Compare March 9, 2023 10:12
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Mar 9, 2023
@radeusgd radeusgd force-pushed the wip/5583-database-column-names-review branch from 3443b75 to cd99809 Compare March 10, 2023 08:31
@jdunkerley jdunkerley added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Ready to merge This PR is eligible for automatic merge labels Mar 10, 2023
@mergify mergify bot merged commit 91ef8ac into develop Mar 10, 2023
@mergify mergify bot deleted the wip/5583-database-column-names-review branch March 10, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
4 participants
@radeusgd @jdunkerley @GregoryTravis @JaroslavTulach