Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Distinct for the Database backends #4027

Merged
merged 19 commits into from
Jan 11, 2023
Merged

Implement Distinct for the Database backends #4027

merged 19 commits into from
Jan 11, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jan 5, 2023

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/182307281

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@radeusgd radeusgd self-assigned this Jan 5, 2023
@radeusgd radeusgd force-pushed the wip/radeusgd/database-distinct-182307281 branch 2 times, most recently from 3be8630 to da71870 Compare January 9, 2023 19:34
@radeusgd radeusgd marked this pull request as ready for review January 9, 2023 20:44
@radeusgd radeusgd force-pushed the wip/radeusgd/database-distinct-182307281 branch from 4480aab to a97d349 Compare January 10, 2023 22:22
jdunkerley
jdunkerley approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

As we have discussed I think we need to look at the IR structure but that is a separate topic.

I'd like to see a CodeGen test for distinct to make it clearer what comes out in that case.

@radeusgd radeusgd force-pushed the wip/radeusgd/database-distinct-182307281 branch from a97d349 to d9da262 Compare January 11, 2023 22:01
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jan 11, 2023
@mergify mergify bot merged commit 0088096 into develop Jan 11, 2023
@mergify mergify bot deleted the wip/radeusgd/database-distinct-182307281 branch January 11, 2023 22:46
@wdanilo wdanilo mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeusgd @jdunkerley