Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic VSCode support for Enso language and development #4014

Merged
merged 10 commits into from
Jan 6, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Dec 31, 2022

Pull Request Description

Basic VSCode support for Enso language and development

Important Notes

See the building instructions.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    style guides.
  • All code has been tested:
    • Build is included in the CI gate

@JaroslavTulach
Copy link
Member Author

Install from VSIX...

@4e6
Copy link
Contributor

4e6 commented Jan 2, 2023

I feel like I should mention this article https://stefan-marr.de/2022/10/effortless-language-servers/ linking a paper that describes how to derive the LSP server for any language built on top of GraalVM. And a repo with a language server example. There are some good ideas that we can use.

Paper comparing low-effort approaches for implementing language servers.

Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that the original TextMate grammar definition (https://github.com/enso-org/enso/blob/develop/tools/enso4igv/src/main/resources/org/enso/tools/enso4igv/enso.tmLanguage.json) was taken from https://github.com/joenash/vscode-enso. Great to see that now, we can build this as an extension straight from Enso, without cloning other repos.

@radeusgd
Copy link
Member

radeusgd commented Jan 2, 2023

I suggest adding

tools/enso4igv/*.vsix
tools/enso4igv/nbcode/

to the .gitignore.

Nevermind, it's already there!

I switched branches back and was confused 😅 Sorry

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
image

@@ -0,0 +1 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant piece of code! 👀

Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Jan 5, 2023
@mergify mergify bot merged commit 0465aa3 into develop Jan 6, 2023
@mergify mergify bot deleted the wip/jtulach/BasicVSCodeExtension_184126398 branch January 6, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants