Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Enso objects are hasheable #3878

Merged
merged 95 commits into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
7e1c03f
Hash codes prototype
Akirathan Nov 15, 2022
c9506ba
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Nov 23, 2022
9d8b61e
Remove Any.hash_code
Akirathan Nov 24, 2022
f3e487c
Improve caching of hashcode in atoms
Akirathan Nov 24, 2022
0c60337
[WIP] Add Hash_Map type
Akirathan Nov 24, 2022
ddcca60
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Dec 22, 2022
96a5b55
Implement Any.hash_code builtin for primitives and vectors
Akirathan Dec 23, 2022
2af691a
Add some values to ValuesGenerator
Akirathan Dec 23, 2022
07e4277
Fix example docs on Time_Zone.new
Akirathan Dec 23, 2022
9160e91
[WIP] QuickFix for HashCodeTest before PR #3956 is merged
Akirathan Dec 23, 2022
62f6101
Fix hash code contract in HashCodeTest
Akirathan Dec 23, 2022
7aac0ff
Add times and dates values to HashCodeTest
Akirathan Dec 23, 2022
97607df
Fix docs
Akirathan Dec 23, 2022
86ec068
Remove hashCodeForMetaInterop specialization
Akirathan Dec 29, 2022
2904d51
Introduce snapshoting of HashMapBuilder
Akirathan Dec 30, 2022
8360264
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Dec 30, 2022
e6cebc7
Add unit tests for EnsoHashMap
Akirathan Dec 30, 2022
4a631a4
Remove duplicate test in Map_Spec.enso
Akirathan Jan 2, 2023
d49f520
Hash_Map.to_vector caches result
Akirathan Jan 3, 2023
f3a89a7
Hash_Map_Spec is a copy of Map_Spec
Akirathan Jan 3, 2023
2f9a353
Implement some methods in Hash_Map
Akirathan Jan 3, 2023
3f6f4dc
Add equalsHashMaps specialization to EqualsAnyNode
Akirathan Jan 3, 2023
0c601c2
get and insert operations are able to work with polyglot values
Akirathan Jan 3, 2023
a666578
Implement rest of Hash_Map API
Akirathan Jan 3, 2023
cf92374
Add test that inserts elements with keys with same hash code
Akirathan Jan 3, 2023
a3356cc
EnsoHashMap.toDisplayString use builder storage directly
Akirathan Jan 3, 2023
65e1942
Add separate specialization for host objects in EqualsAnyNode
Akirathan Jan 3, 2023
0bbbf4d
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 4, 2023
dc43cd7
Fix specialization for host objects in EqualsAnyNode
Akirathan Jan 5, 2023
a5bc43d
Add polyglot hash map tests
Akirathan Jan 5, 2023
04d19b1
EconomicMap keeps reference to EqualsNode and HashCodeNode.
Akirathan Jan 5, 2023
bc2f57e
HashMapTest run in polyglot context
Akirathan Jan 5, 2023
f3696df
Fix containsKey index handling in snapshots
Akirathan Jan 5, 2023
e19dc03
Remove snapshots field from EnsoHashMapBuilder
Akirathan Jan 5, 2023
ddf0096
Prepare polyglot hash map handling.
Akirathan Jan 5, 2023
b4c6af1
Some bug fixes
Akirathan Jan 6, 2023
29b0e7b
Remove ForeignMapWrapper.
Akirathan Jan 6, 2023
dcc9609
Improve performance of Hash_Map.get_builtin
Akirathan Jan 6, 2023
7f2ccb4
Remove to_flat_vector.
Akirathan Jan 6, 2023
28da4ad
Fix polyglot hash maps method dispatch
Akirathan Jan 6, 2023
c85a9da
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 9, 2023
577e469
Add tests that effectively test hash code implementation.
Akirathan Jan 9, 2023
a99472c
Remove Hashcode_Spec
Akirathan Jan 9, 2023
181b822
Add some polyglot tests
Akirathan Jan 9, 2023
97ac4ad
Add Text.== tests for NFD normalization
Akirathan Jan 9, 2023
4d9af31
Fix NFD normalization bug in Text.java
Akirathan Jan 9, 2023
19fbfc1
Improve performance of EqualsAnyNode.equalsTexts specialization
Akirathan Jan 9, 2023
f01f252
Properly compute hash code for Atom and cache it
Akirathan Jan 9, 2023
8d69f03
Fix Text specialization in HashCodeAnyNode
Akirathan Jan 9, 2023
5989331
Add Hash_Map_Spec as part of all tests
Akirathan Jan 9, 2023
5a3a013
Remove HashMapTest.java
Akirathan Jan 10, 2023
d0d179c
Remove rest of identityHashCode message implementations
Akirathan Jan 10, 2023
38d34b3
Replace old Map with Hash_Map
Akirathan Jan 10, 2023
1731fed
Add some docs
Akirathan Jan 10, 2023
56c6322
Add TruffleBoundaries
Akirathan Jan 10, 2023
8a5244d
Formatting
Akirathan Jan 10, 2023
f3a3c67
Fix some tests to accept unsorted vector from Map.to_vector
Akirathan Jan 10, 2023
e1dae7d
Delete Map.first and Map.last methods
Akirathan Jan 10, 2023
50d064c
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 10, 2023
4b8ce98
Add specialization for big integer hash
Akirathan Jan 10, 2023
cc5284e
Introduce proper HashCodeTest and EqualsTest.
Akirathan Jan 11, 2023
ca14fa5
Fix some specializations for primitives in HashCodeAnyNode
Akirathan Jan 11, 2023
6293b80
Fix host object specialization
Akirathan Jan 11, 2023
fd3565e
Remove Any.hash_code
Akirathan Jan 11, 2023
c8640f0
Fix import in Map.enso
Akirathan Jan 11, 2023
77cb741
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 11, 2023
b121636
Update changelog
Akirathan Jan 12, 2023
6d33ae7
Reformat
Akirathan Jan 12, 2023
d81eff2
Add truffle boundary to BigInteger.hashCode
Akirathan Jan 12, 2023
cd6b5d5
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 12, 2023
ff8809a
Fix performance of HashCodeTest - initialize DataPoints just once
Akirathan Jan 12, 2023
5be08ad
Fix MetaIsATest
Akirathan Jan 13, 2023
8d814e6
Fix ValuesGenerator.textual - Java's char is not Text
Akirathan Jan 13, 2023
03b5605
Fix indent in Map_Spec.enso
Akirathan Jan 13, 2023
4d9cc18
Add maps to datapoints in HashCodeTest
Akirathan Jan 13, 2023
1ac3a32
Add specialization for maps in HashCodeAnyNode
Akirathan Jan 13, 2023
ca7543b
Add multiLevelAtoms to ValuesGenerator
Akirathan Jan 13, 2023
83868d0
Provide a workaround for non-linear key inserts
Akirathan Jan 17, 2023
af6b29b
Fix specializations for double and BigInteger
Akirathan Jan 17, 2023
3342d17
Cosmetics
Akirathan Jan 17, 2023
871ad4a
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 17, 2023
d3e2274
Add truffle boundaries
Akirathan Jan 17, 2023
3010319
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 17, 2023
bc953f9
Add allowInlining=true to some truffle boundaries.
Akirathan Jan 17, 2023
ee1ab69
Increase the size of vectors, and warmup time for Vector.Distinct ben…
Akirathan Jan 17, 2023
2381712
Various small performance fixes.
Akirathan Jan 17, 2023
80c286d
Fix Geo_Spec tests to accept unsorted Map.to_vector
Akirathan Jan 17, 2023
cc24db8
Implement Map.remove
Akirathan Jan 18, 2023
94e7606
FIx Visualization tests to accept unsorted Map.to_vector
Akirathan Jan 18, 2023
52bad4e
Treat java.util.Properties as Map
Akirathan Jan 18, 2023
4557e9f
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 18, 2023
1085f66
Add truffle boundaries
Akirathan Jan 18, 2023
060650a
Invoke polyglot methods on java.util.Properties
Akirathan Jan 18, 2023
787e321
Ignore python tests if python lang is missing
Akirathan Jan 19, 2023
68db5a3
Merge branch 'develop' into wip/akirathan/hashes-181027272
Akirathan Jan 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@
[3964]: https://github.com/enso-org/enso/pull/3964
[3967]: https://github.com/enso-org/enso/pull/3967
[3987]: https://github.com/enso-org/enso/pull/3987
[3878]: https://github.com/enso-org/enso/pull/3878
[3997]: https://github.com/enso-org/enso/pull/3997
[4013]: https://github.com/enso-org/enso/pull/4013
[4026]: https://github.com/enso-org/enso/pull/4026
Expand Down Expand Up @@ -514,6 +515,7 @@
- [Sync language server with file system after VCS restore][4020]
- [`ArrayOverBuffer` behaves like an `Array` and `Array.sort` no longer sorts in
place][4022]
- [Implement hashing functionality for all objects][3878]
- [Introducing Meta.atom_with_hole][4023]
- [Report failures in name resolution in type signatures][4030]
- [Attach visualizations to sub-expressions][4048]
Expand Down
Loading