Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add business days functions to Date and Date_Time #3726

Merged
merged 22 commits into from
Sep 22, 2022
Merged

Add business days functions to Date and Date_Time #3726

merged 22 commits into from
Sep 22, 2022

Commits on Sep 21, 2022

  1. Add method signatures

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    c1da0f2 View commit details
    Browse the repository at this point in the history

  2. checkpoint

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    96a4d63 View commit details
    Browse the repository at this point in the history

  3. Add tests for Date 

    TODO once this is implemented we want an analogous test suite for
Date_Time
    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    e69b374 View commit details
    Browse the repository at this point in the history

  4. Implement work_days_until, for now ignoring the holidays

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    4eb74d3 View commit details
    Browse the repository at this point in the history

  5. Take holidays into account

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    2bca481 View commit details
    Browse the repository at this point in the history

  6. Add preliminary tests for Date_Time.work_days_until, 

    some spec clarifications are still needed
    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    2a20b99 View commit details
    Browse the repository at this point in the history

  7. Prototype add_work_days 

    Does not work yet (:
    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    e9d50d7 View commit details
    Browse the repository at this point in the history

  8. Removed work_days_until from Date_Time as the notion is not really we… 

    …ll-defined.

Users can manually convert to Date and then the intent is much much clearer.
    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    1dbbadd View commit details
    Browse the repository at this point in the history

  9. Add tests for negative shift, check expected relative properties of t… 

    …he two functions
    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    09cb4fb View commit details
    Browse the repository at this point in the history

  10. WIP add_work_days, add new option to work_days_until and NETWORKDAYS … 

    …tests
    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    98908ca View commit details
    Browse the repository at this point in the history

  11. fix a test

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    fd3a430 View commit details
    Browse the repository at this point in the history

  12. Implement holidays handling, at least for positive dates

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    86f40f5 View commit details
    Browse the repository at this point in the history

  13. Initial implementation for negative shift, 

    still there may be some off by one error
    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    9b0c38d View commit details
    Browse the repository at this point in the history

  14. add some more tests, fix logic for computing weekday shift

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    8317b18 View commit details
    Browse the repository at this point in the history

  15. changelog

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    4ed863d View commit details
    Browse the repository at this point in the history

  16. Add tests for Date_Time, fix tail calls

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    5cf12fe View commit details
    Browse the repository at this point in the history

  17. formatting

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    dee2d3f View commit details
    Browse the repository at this point in the history

  18. more docs

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    68c4a0f View commit details
    Browse the repository at this point in the history

  19. Switch get_or_else implementation with get to make it more efficient

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    1f48800 View commit details
    Browse the repository at this point in the history

  20. Fix Vector.distinct (and some others) creating an error instance too … 

    …eagerly
    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    7adf4c1 View commit details
    Browse the repository at this point in the history

  21. cr

    @radeusgd
    radeusgd committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    de5d72d View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Make tests check for stack overflow and mark tail callsites to avoid it

    @radeusgd
    radeusgd committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    8a98ebc View commit details
    Browse the repository at this point in the history