Substitute this with self #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
requested review from
4e6,
jdunkerley,
radeusgd and
JaroslavTulach
as code owners
|
I dare anyone to review |
hubertp
force-pushed
the
wip/hubert/this-to-self-182328601
branch
2 times, most recently
from
8a18dfb
to
a97e223
Compare
I've got a long train ride tomorrow evening, so challenge accepted ^^ |
radeusgd
reviewed
Jun 14, 2022
radeusgd
reviewed
Jun 14, 2022
|
|
||
| ## Checks equality of numbers, using an `epsilon` value. | ||
|
|
||
| Arguments: | ||
| - that: The number to check equality against. | ||
| - epsilon: The value by which `this` and `that` can be separated by before | ||
| - epsilon: The value by which `self` and `that` can be separated by before |
There was a problem hiding this comment.
I wonder what we should do about these?
this and that sounded nicely, now, not sure if we should change that to something else? But I'm not sure if there are good alternatives either.
There was a problem hiding this comment.
Yes, this is something @ekmett raised as well
radeusgd
reviewed
Jun 14, 2022
distribution/lib/Standard/Base/0.0.0-dev/src/System/File/Option.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Jun 14, 2022
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Column.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Jun 14, 2022
lib/scala/interpreter-dsl/src/main/java/org/enso/interpreter/dsl/model/MethodDefinition.java
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Jun 14, 2022
JaroslavTulach
approved these changes
Jun 15, 2022
A semi-manual s/this/self appied to the whole standard library. Related to https://www.pivotaltracker.com/story/show/182328601 In the compiler promoted to use constants instead of hardcoded `this`/`self` whenever possible.
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
hubertp
force-pushed
the
wip/hubert/this-to-self-182328601
branch
from
9c65e5c
to
19b4c91
Compare
hubertp
requested review from
MichaelMauderer,
wdanilo and
farmaazon
as code owners
|
@MichaelMauderer @mwu-tow @wdanilo @farmaazon please ignore everything apart from |
wdanilo
approved these changes
Jun 21, 2022
kazcw
pushed a commit
that referenced
this pull request
Jun 29, 2022
A semi-manual s/this/self appied to the whole standard library. Related to https://www.pivotaltracker.com/story/show/182328601 In the compiler promoted to use constants instead of hardcoded `this`/`self` whenever possible. # Important Notes The PR **does not** require explicit `self` parameter declaration for methods as this part of the design is still under consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
A semi-manual s/this/self appied to the whole standard library.
Related to https://www.pivotaltracker.com/story/show/182328601
In the compiler promoted to use constants instead of hardcoded
this/selfwhenever possible.Important Notes
The PR does not require explicit
selfparameter declaration for methods as this partof the design is still under consideration.
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide distand./run ide watch.