Generate BuiltinMethods from simple method and constructor signatures #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A low-hanging fruit where we can automate the generation of many @BuiltinMethod nodes simply from the runtime's methods signatures. This change introduces another annotation, @Builtin, to distinguish from @BuiltinType and @BuiltinMethod processing. @Builtin processing will always be the first stage of processing and its output will be fed to the latter. Note that the return type of Array.length() is changed from `int` to `long` because we probably don't want to add a ton of specializations for the former (see comparator nodes for details) and it is fine to cast it in a small number of places. Progress is visible in the number of deleted hardcoded classes. This is an incremental step towards #181499077.
JaroslavTulach
approved these changes
May 10, 2022
lib/scala/interpreter-dsl/src/main/java/org/enso/interpreter/dsl/BuiltinsProcessor.java
Outdated
Show resolved
Hide resolved
lib/scala/interpreter-dsl/src/main/java/org/enso/interpreter/dsl/BuiltinsProcessor.java
Outdated
Show resolved
Hide resolved
| out.println("import " + ownerClazz.fullyQualifiedName() + ";"); | ||
| out.println(); | ||
| out.println( | ||
| "@BuiltinMethod(type = \"" |
There was a problem hiding this comment.
A processor that generates code for another processor - that's metacyclic!
4e6
reviewed
May 11, 2022
lib/scala/interpreter-dsl/src/main/java/org/enso/interpreter/dsl/BuiltinsProcessor.java
Outdated
Show resolved
Hide resolved
Overriding supported version in processors manually is the only way to keep it quiet when using Frgaal. Thanks for the suggestion Jaroslav!
hubertp
changed the title
Extended the initial approach to also generate `Foo.new` builtin methods when @Builtin is added to the constructor. `NewNode` for `Array` is now gone. For consistency, the generated one will now be called `NewArrayNode`.
hubertp
changed the title
|
Now also handling simple constructors = profit! |
4e6
approved these changes
May 12, 2022
7 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2022
This is the 2nd part of DSL improvements that allow us to generate a lot of builtins-related boilerplate code. - [x] generate multiple method nodes for methods/constructors with varargs - [x] expanded processing to allow for @Builtin to be added to classes and and generate @BuiltinType classes - [x] generate code that wraps exceptions to panic via `wrapException` annotation element (see @Builtin.WrapException` Also rewrote @Builtin annotations to be more structured and introduced some nesting, such as @Builtin.Method or @Builtin.WrapException. This is part of incremental work and a follow up on #3444. # Important Notes Notice the number of boilerplate classes removed to see the impact. For now only applied to `Array` but should be applicable to other types.
kustosz
reviewed
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
A low-hanging fruit where we can automate the generation of many
@BuiltinMethod nodes simply from the runtime's methods signatures.
This change introduces another annotation, @Builtin, to distinguish from
@BuiltinType and @BuiltinMethod processing. @Builtin processing will
always be the first stage of processing and its output will be fed to
the latter.
Note that the return type of Array.length() is changed from
inttolongbecause we probably don't want to add a ton of specializationsfor the former (see comparator nodes for details) and it is fine to cast
it in a small number of places.
Progress is visible in the number of deleted hardcoded classes.
This is an incremental step towards #181499077.
Important notes
This process does not attempt to cover all cases. Not yet, at least.
We only handle simple methods and constructors (see removed
Arrayboilerplate methods).Checklist
Please include the following checklist in your PR:
./run distand./run watch.