Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File_Format.Excel work #3425

Merged
merged 28 commits into from
May 6, 2022
Merged

File_Format.Excel work #3425

merged 28 commits into from
May 6, 2022

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Apr 28, 2022 •
edited
Loading

Pull Request Description

  • Read in Excel files following the specification.
  • Support for XLSX and XLS formats.
  • Ability to select ranges and sheets.
  • Skip Rows and Row Limits.

Important Notes

  • Minor fix to DelimitedReader for Windows

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.

@jdunkerley jdunkerley force-pushed the wip/jd/excel-181824200 branch 2 times, most recently from 981d600 to e8f87a7 Compare May 4, 2022 09:43
@jdunkerley jdunkerley marked this pull request as ready for review May 4, 2022 13:42
radeusgd
radeusgd requested changes May 5, 2022
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd add some more documentation here and there, especially to the public parts of the API.
Some minor code style suggestions.

distribution/lib/Standard/Table/0.0.0-dev/src/Error.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Io/Excel.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Io/Excel.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Io/Excel.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Io/Excel.enso Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/format/xlsx/Range.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/format/xlsx/Range.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/format/xlsx/Reader.java Show resolved Hide resolved
test/Table_Tests/src/Excel_Spec.enso Outdated Show resolved Hide resolved
test/Table_Tests/src/Excel_Spec.enso Show resolved Hide resolved
@jdunkerley jdunkerley requested a review from radeusgd May 5, 2022 16:18
@jdunkerley jdunkerley requested a review from radeusgd May 6, 2022 09:03
hubertp
hubertp approved these changes May 6, 2022
View reviewed changes
distribution/lib/Standard/Table/0.0.0-dev/src/Io/Excel.enso
Arguments:
- file: The File object to read.
- section: The part of the Excel document to read.
- on_problems: Specifies the behavior when a problem occurs during the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ignored on purpose?

std-bits/table/src/main/java/org/enso/table/format/xlsx/Range.java Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/format/xlsx/Range.java Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/format/xlsx/Reader.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/format/xlsx/Reader.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/format/xlsx/Reader.java Show resolved Hide resolved
radeusgd
radeusgd reviewed May 6, 2022
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, but a few docs are missing and some inconsistencies that would be cool if addressed.

distribution/lib/Standard/Table/0.0.0-dev/src/Io/Excel.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Io/Excel.enso Outdated Show resolved Hide resolved
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label May 6, 2022
@mergify mergify bot merged commit 078c665 into develop May 6, 2022
@mergify mergify bot deleted the wip/jd/excel-181824200 branch May 6, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@hubertp hubertp hubertp approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdunkerley @hubertp @radeusgd