-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data analysts should be able to use Text.split
, Text.lines
and Text.words
to break up strings
#3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
approved these changes
Apr 25, 2022
jdunkerley
requested changes
Apr 25, 2022
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Extensions.enso
Outdated
Show resolved
Hide resolved
Generally looks good - a couple of bits to just look over |
jdunkerley
approved these changes
Apr 26, 2022
radeusgd
force-pushed
the
wip/radeusgd/text-split-new-181266184
branch
from
April 26, 2022 10:03
736a374
to
e9f0c6b
Compare
The file is downloaded by the Enso example itself on-demand.
radeusgd
force-pushed
the
wip/radeusgd/text-split-new-181266184
branch
from
April 26, 2022 12:21
f0732f3
to
8ded379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/181266184
Important Notes
Changed example image download to only proceed if the file did not exist before - thus cutting on the build time (the build used to download it every time - which completely failed the build if network is down). A redownload can be forced by performing a fresh repository checkout.
Checklist
Please include the following checklist in your PR:
./run dist
and./run watch
.