Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data analysts should be able to use Text.split, Text.lines and Text.words to break up strings #3415

Merged
merged 13 commits into from
Apr 26, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Apr 25, 2022

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/181266184

Important Notes

Changed example image download to only proceed if the file did not exist before - thus cutting on the build time (the build used to download it every time - which completely failed the build if network is down). A redownload can be forced by performing a fresh repository checkout.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@radeusgd radeusgd self-assigned this Apr 25, 2022
@jdunkerley
Copy link
Member

Generally looks good - a couple of bits to just look over

@radeusgd radeusgd force-pushed the wip/radeusgd/text-split-new-181266184 branch from 736a374 to e9f0c6b Compare April 26, 2022 10:03
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Apr 26, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/text-split-new-181266184 branch from f0732f3 to 8ded379 Compare April 26, 2022 12:21
@mwu-tow mwu-tow merged commit 14257d0 into develop Apr 26, 2022
@mwu-tow mwu-tow deleted the wip/radeusgd/text-split-new-181266184 branch April 26, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants