Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data analysts should be able to transform a Table using the remove_columns and reorder_columns functions #3240

Merged
merged 13 commits into from
Feb 3, 2022
Merged

Data analysts should be able to transform a Table using the remove_columns and reorder_columns functions #3240

merged 13 commits into from
Feb 3, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jan 31, 2022 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Jan 31, 2022
@radeusgd radeusgd marked this pull request as ready for review January 31, 2022 16:25
jdunkerley
jdunkerley requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the changelog updated but otherwise looks good

wdanilo
wdanilo approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

Base automatically changed from wip/radeusgd/select-columns-180794249 to develop February 2, 2022 09:04
@radeusgd radeusgd force-pushed the wip/radeusgd/remove-columns-180994905 branch from dc988d6 to 11578fe Compare February 2, 2022 11:32
@radeusgd radeusgd changed the title Data analysts should be able to transform a Table using the remove_columns function to remove columns. Data analysts should be able to transform a Table using the remove_columns and reorder_columns functions Feb 2, 2022
@radeusgd radeusgd merged commit d3c0f96 into develop Feb 3, 2022
@radeusgd radeusgd deleted the wip/radeusgd/remove-columns-180994905 branch February 3, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@wdanilo wdanilo wdanilo approved these changes

@4e6 4e6 4e6 approved these changes

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@MichaelMauderer MichaelMauderer Awaiting requested review from MichaelMauderer

@mwu-tow mwu-tow Awaiting requested review from mwu-tow

Assignees

@radeusgd radeusgd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radeusgd @4e6 @wdanilo @jdunkerley