-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored enso-data
crate and text utilities.
#3166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do some more testing based on a list like the Big List of Naughty Strings? That could make sure we didn't miss any corner cases.
@@ -873,6 +873,16 @@ impl AreaModel { | |||
_ => None, | |||
} | |||
} | |||
|
|||
/// Constrain the selection to values valid inside of the current text buffer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be useful to explain valid
according to what rules.
Well, I'm sure that we won't work properly on those naughty strings, because this task resolves only one sort of problems (others are covered by https://www.pivotaltracker.com/n/projects/2539304/stories/180392693) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocker, just for consideration: I'd rather see explicit unit::Bytes
to avoid confusion with bytes::Bytes
, also singular Byte
might make more sense than Bytes
If it is not a hard blocker, I would skip it for a while. I tried to apply this, but some things does not look well: pub fn first_line_start_column(&self) -> unit::Column looks strangely to me: Without context, I would not know what |
Pull Request Description
This is implementation of task https://www.pivotaltracker.com/n/projects/2539304/stories/180312587. The old
enso-data
crate was renamed toenso-data-structures
and designed to have only those: data structures.That required moving the structures related to Text positions (the
text
module containingIndex
andSpan
). Because the EnsoGL text area component has structures duplicating functionalities, they were moved to a separateenso-text
crate and replaced the old usages ofIndex
andSpan
.Important Notes
Checklist
Please include the following checklist in your PR: