Widgets are aligned to top #14267
Widgets are aligned to top #14267
Conversation
farmaazon
requested review from
AdRiley,
Frizi,
PabloBuchu,
indiv0,
kazcw,
somebody1234 and
vitvakatu
as code owners
I think |
|
Because drop down started looking bad in "expanded" nodes, I changed their style to more "generic pill" (same as in submenus): 
@AdRiley is it good enough? |
…/widgets-align-to-top
kazcw
left a comment
kazcw
left a comment
There was a problem hiding this comment.
Code looks good; introduces new concepts that I think are worth documenting
| .content { | ||
| } |
| } | ||
| } | ||
|
|
||
| /** A class used in widgets of their fragments not higher than node's "baseline" */ |
There was a problem hiding this comment.
| /** A class used in widgets of their fragments not higher than node's "baseline" */ | |
| /** A class used in widgets or their fragments not higher than node's "baseline" */ |
| /** A class for widgets which want to expand their height to the entire node */ | ||
| .widgetExpanded { | ||
| align-self: stretch | ||
| } |
There was a problem hiding this comment.
It's not obvious to me when these should be used. Questions I have are:
- Is it OK for a widget not to use any of these classes?
- Can a widget use more than one class?
- If a widget is conditionally a parent, should it only use
widgetParentconditionally? - What is a "fragment"?
These classes are used in a way that works now, but some clarification of their intended usage may make it easier to apply them correctly to new widgets, and ensure that they are used in a consistent way so that if we change the styling of these classes in the future side-effects are minimized.
|
@kazcw I tried to improve docs for css classes. Are they good for you, or you still miss something? |
Pull Request Description
Fixes #14138
Important Notes
Ports are now stretched to the entire node's height. It doesn't look good, but I don't quite know how to make them "shrink" to content size, while still allowing content to be stretched if needed.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.