Skip to content

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

A prelude to #13491

Move upload file logic to Vue. It will be needed when handling hybrid projects.

Important Notes

Because of various problems with tanstack query we faced lately, which were hard to debug, I decided to not use it in the new implementation. I moved the "pooling" mechanism to the new store.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • [ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@farmaazon farmaazon self-assigned this Oct 3, 2025
@farmaazon farmaazon added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 3, 2025
@farmaazon farmaazon changed the title Wip/farmaazon/projects lifetime1 Move Upload File to Cloud logic to Vue Oct 6, 2025
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@farmaazon
Copy link
Contributor Author

@somebody1234 I re-requested review, as I did a significant change:

  1. Restored mutations, as they seem to be required for proper asset list refreshing
  2. Added simplified logic for local file upload.

@farmaazon farmaazon force-pushed the wip/farmaazon/projects-lifetime1 branch from 5cad39b to 0aabdcf Compare October 14, 2025 14:10
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants