-
Notifications
You must be signed in to change notification settings - Fork 332
Defining to_text
& co. as extension methods
#14050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
to_text
& co. as extension methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to need to add from project.Data.Text.Extensions import all
to a lot of files in Standard.Base
.
Think about 57 files need it added,
|
Take This would have worked previously but will now error as this code does not import Text extensions. |
Ones I suspect (but maybe false positives):
|
|
Pull Request Description
>
,>=
,<
,<=
to types where such operators make sense #14017Any
#13978|>
operator to Function #14004from Standard.Base import all
Important Notes
to_text
inAny
pretty
andto_display_text
clearly seem weirdTObject
had no methods at all!Any.to
is perfectly fine in the root typeto_display_text
,pretty
out ofAny
is a completely legitimate goalChecklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.