Playwright testing Enso 101, exercise 2 #13951
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otulach
requested review from
Frizi,
farmaazon,
vitvakatu,
kazcw,
AdRiley,
PabloBuchu,
indiv0 and
somebody1234
as code owners
otulach
added
the
CI: No changelog needed
vitvakatu
reviewed
Sep 9, 2025
| visualizeData, | ||
| } from './electronTest' | ||
|
|
||
| // First excercise in Enso Analytics 101 |
There was a problem hiding this comment.
Suggested change
| // First excercise in Enso Analytics 101 | |
| // Second excercise in Enso Analytics 101 |
There was a problem hiding this comment.
also excercise -> exercise
Comment on lines
+73
to
+76
| // If dropdown menu doesn't open, click groupBy again to avoid test flakyness | ||
| if (!(await productBtn.isVisible())) { | ||
| await groupBy.click() | ||
| } |
There was a problem hiding this comment.
I don’t think we avoid a flaky test here. Why does it not work on the first attempt? Perhaps we can wait for some visual indication that it is ready? Or is there some bug that prevents it from working?
Comment on lines
+84
to
+89
| await page | ||
| .locator('div.WidgetTopLevelArgument', { hasText: 'columns' }) | ||
| .getByRole('list') | ||
| .filter({ hasText: /^$/ }) | ||
| .getByLabel('Add a new item') | ||
| .click() |
There was a problem hiding this comment.
There are three repetitions of this action; let’s extract it to a function.
Comment on lines
+165
to
+171
| await crossTab.hover() | ||
| await page.mouse.down() | ||
| const box = await crossTab.boundingBox() | ||
| if (box) { | ||
| await page.mouse.move(box.x + box.width / 2, box.y + box.height / 2 + 200) | ||
| } | ||
| await page.mouse.up() |
There was a problem hiding this comment.
There is an easier way to do dragging. Check out moveNode in collapsingAndEntering.spec.ts:
function moveNode(page: Page, binding: string, relativePos: RelativePos) {
return grabNode(page, binding).dragTo(grabNode(page, relativePos.relativeTo ?? binding), {
force: true,
targetPosition: relativePos,
})
}grabNode can be replaced with graphNodeIcon, it’s an oversight on my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds Playwright tests for Exercise 2 of the Enso Analytics 101 walkthrough:
https://community.ensoanalytics.com/c/enso-analytics-101/sections/637012/lessons/2410664
Exercise 2: Data Aggregation & Pivoting
Includes:
aggregateto count accounts by product type.sortto rank top-performing products.cross_tabfor multi-dimensional analysis.setto fix entry errors.Outcome
Tests the overall functionality of Exercise 2. Divided into separate objectives for better readability.